Just a non-professional opinion: I think it's kind of like how designers said high-waisted jeans were coming back, but most people don't have the guts to wear them. People are going to have strong opinions about brass-either love it or hate it. If your house is in a high-price range, you may want to opt for something more neutral. Otherwise, I would say leave it, as many people will want to redecorate to their own taste anyways.

If it is in good shape, I would leave it. Most people don't notice door hardware all that much if it works.

If you have a bright brass hanging fixture or two that are clearly in the fashion of when the house was built, that would be something that would be easy to change, IF you wanted to.

I would study what other houses like yours on the market look like when you put it on and/or only change something if you got a lot of feedback that XYZ was holding someone back from making an offer.

Just because something is coming back in style doesn't mean that it will be it's old version. The brass that's been popping up in decor magazines isn't the bright lacquered brass from the 80's or the "antiqued brass" from the 70's. It's more of a "natural brass". Not bright and shiny, but not dark and aged either. Somewhere in between. More of a muted gold.

If resale is that long away, I wouldn't worry about what's in style now or what may be coming. Worry about that 24 months from now. Hardware and lighting are quick easy fixes that won't take more than a week to accomplish and you'll have the perspective of two more years of changing styles to choose your products from.

Thanks, everyone. I feel better! Love all the knowledge here. :-)